Messages in this thread | | | Date | Thu, 16 Sep 2021 11:26:18 +0000 | From | Michael Heimpold <> | Subject | Re: [PATCH RFC 3/3] net: vertexcom: Add MSE102x SPI support |
| |
Hi Andrew,
Zitat von Andrew Lunn <andrew@lunn.ch>:
>> +static int mse102x_probe_spi(struct spi_device *spi) >> +{ > > ... > >> + netif_carrier_off(mse->ndev); >> + ndev->if_port = IF_PORT_10BASET; > > That is not correct. Maybe you should add a IF_PORT_HOMEPLUG ?
Would a simple IF_PORT_HOMEPLUG be sufficient, or should it be more precise as for Ethernet (10BASET, 100BASET...), e.g. IF_PORT_HOMEPLUG_10 IF_PORT_HOMEPLUG_AV IF_PORT_HOMEPLUG_AV2 IF_PORT_HOMEPLUG_GREENPHY
Thanks, Michael
[unhandled content-type:application/pgp-keys] | |