| From | Linus Walleij <> | Date | Thu, 16 Sep 2021 23:57:56 +0200 | Subject | Re: [RFC PATCH v1 13/20] tools: gpio: Add event count capability to event monitor application |
| |
On Tue, Aug 24, 2021 at 6:48 PM <lakshmi.sowjanya.d@intel.com> wrote:
> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> > > Add -t command line flag requesting event count to the gpio-event-mon > application. If event count is unsupported an invalid argument error is > returned by GPIOlib and the application exits with an error. The event > count is printed with the event type and timestamp. > > Co-developed-by: Christopher Hall <christopher.s.hall@intel.com> > Signed-off-by: Christopher Hall <christopher.s.hall@intel.com> > Signed-off-by: Tamal Saha <tamal.saha@intel.com> > Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> > Reviewed-by: Mark Gross <mgross@linux.intel.com>
This looks wrong.
If this hardware can report timestamped events, which I believe it does, each event should be reported to userspace uniquely, ideally using the native timestamp, and using the in-progress HTE subsystem.
Yours, Linus Walleij
|