lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 122/380] platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit 0487d4fc42d7f31a56cfd9e2237f9ebd889e6112 ]

    As pointed out be Kees Cook if we return -EIO because the
    obj->type != ACPI_TYPE_BUFFER, then we must kfree the
    output buffer before the return.

    Fixes: 1a258e670434 ("platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver")
    Reported-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20210826140822.71198-1-hdegoede@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/dell/dell-smbios-wmi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/platform/x86/dell/dell-smbios-wmi.c b/drivers/platform/x86/dell/dell-smbios-wmi.c
    index 33f823772733..8e761991455a 100644
    --- a/drivers/platform/x86/dell/dell-smbios-wmi.c
    +++ b/drivers/platform/x86/dell/dell-smbios-wmi.c
    @@ -69,6 +69,7 @@ static int run_smbios_call(struct wmi_device *wdev)
    if (obj->type == ACPI_TYPE_INTEGER)
    dev_dbg(&wdev->dev, "SMBIOS call failed: %llu\n",
    obj->integer.value);
    + kfree(output.pointer);
    return -EIO;
    }
    memcpy(&priv->buf->std, obj->buffer.pointer, obj->buffer.length);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 18:42    [W:6.290 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site