lkml.org 
[lkml]   [2021]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Date
Dne sreda, 15. september 2021 ob 07:47:31 CEST je Dang Huynh napisal(a):
> On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej Škrabec wrote:
> > > +&simplefb_hdmi {
> > > + vcc-hdmi-supply = <&reg_dldo1>;
> >
> > You have to set status to okay here.

Sorry, this is actually the job of bootloader, so it's all good.

> >
> > With that fixed, you can add:

No fixing needed for R-b tag.

> > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> >
> > Best regards,
> > Jernej
> >
>
> Is it really needed? The DE2 HDMI driver can be loaded and make this pretty
> much obsolete.

DE2 and HDMI driver could read current settings from that node and implement
flicker free transition. However, that's not supported yet. Another use case is
to optimize kernel size to minimum for storing it in SPI flash by removing DRM
driver if simplefb is good enough.

Anyway, patch looks good. Thanks!

Best regards,
Jernej


\
 
 \ /
  Last update: 2021-09-15 18:31    [W:0.413 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site