lkml.org 
[lkml]   [2021]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl
    On 14.09.2021 11:11:25, Jiri Slaby wrote:
    > After the previous patches, noone needs 'file' parameter in neither
    > ioctl hook from tty_ldisc_ops. So remove 'file' from both of them.
    >
    [...]
    > diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c
    > index 9a4ebda30510..de2da1b09a79 100644
    > --- a/drivers/net/can/slcan.c
    > +++ b/drivers/net/can/slcan.c
    > @@ -670,8 +670,8 @@ static void slcan_hangup(struct tty_struct *tty)
    > }
    >
    > /* Perform I/O control on an active SLCAN channel. */
    > -static int slcan_ioctl(struct tty_struct *tty, struct file *file,
    > - unsigned int cmd, unsigned long arg)
    > +static int slcan_ioctl(struct tty_struct *tty, unsigned int cmd,
    > + unsigned long arg)
    > {
    > struct slcan *sl = (struct slcan *) tty->disc_data;
    > unsigned int tmp;

    nitpick:
    Checkpatch complains about this:

    | CHECK: Alignment should match open parenthesis
    | #674: FILE: drivers/net/can/slcan.c:674:
    | +static int slcan_ioctl(struct tty_struct *tty, unsigned int cmd,
    | + unsigned long arg)

    Same for other hunks in this file.

    regards,
    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-09-15 10:05    [W:4.141 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site