lkml.org 
[lkml]   [2021]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] x86/mce/mce-inject: Return error code to userspace from mce-inject module
    Date
    Currently, the mce-inject module fails silently and user must look for
    kernel logs to determine if the injection has succeeded.

    Save time for the user and return error code from the module if error
    injection fails.

    Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
    ---
    arch/x86/kernel/cpu/mce/inject.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
    index c7d1564f244b..0ef9ff921c6a 100644
    --- a/arch/x86/kernel/cpu/mce/inject.c
    +++ b/arch/x86/kernel/cpu/mce/inject.c
    @@ -549,8 +549,10 @@ static void do_inject(void)
    }

    cpus_read_lock();
    - if (!cpu_online(cpu))
    + if (!cpu_online(cpu)) {
    + mce_err.err = -ENODEV;
    goto err;
    + }

    toggle_hw_mce_inject(cpu, true);

    @@ -622,7 +624,7 @@ static int inj_bank_set(void *data, u64 val)
    /* Reset injection struct */
    setup_inj_struct(&i_mce);

    - return 0;
    + return mce_err.err;
    }

    MCE_INJECT_GET(bank);
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-09-16 01:29    [W:4.247 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site