Messages in this thread | | | Date | Tue, 14 Sep 2021 12:33:33 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 09/16] x86: Use an opaque type for functions not callable from C |
| |
On Tue, Sep 14, 2021 at 12:10:38PM -0700, Sami Tolvanen wrote: > The kernel has several assembly functions that are not directly callable > from C. Use an opaque type for these function prototypes to make misuse > harder, and to avoid the need to annotate references to these functions > for Clang's Control-Flow Integrity (CFI). > > Suggested-by: Andy Lutomirski <luto@amacapital.net> > Suggested-by: Alexander Lobakin <alobakin@pm.me> > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
This looks clean to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |