Messages in this thread | | | Subject | Re: [PATCH 6/9] s390/block/dasd_genhd: add error handling support for add_disk() | From | Jan Höppner <> | Date | Mon, 13 Sep 2021 14:15:10 +0200 |
| |
On 13/09/2021 10:42, Christoph Hellwig wrote: > On Mon, Sep 13, 2021 at 10:17:48AM +0200, Jan H??ppner wrote: >> I think, just like with some of the other changes, there is some >> cleanup required before returning. I'll prepare a patch and >> come back to you. > > If you are touching the dasd probe path anyway, can you look insto > switching to use blk_mq_alloc_disk as well? Right now dasd allocates > the request_queue and gendisk separately in different stages of > initialization, but unlike SCSI which needs to probe using just the > request_queue I can't find a good reason for that. >
Thanks for the hint. We'll be working on it separately though, as it seems to require a bit more effort from a first glance. We'll send a separate patch (or patchset) soon.
regards, Jan
| |