lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/8] dt-bindings: leds: Convert register-bit-led binding to DT schema
    On Mon, Sep 13, 2021 at 9:28 PM Rob Herring <robh@kernel.org> wrote:

    > Convert the register-bit-led binding to DT schema format.
    >
    > As the example just repeats nearly identical nodes, trim it down to a
    > few nodes and use some documented values for 'linux,default-trigger'.
    >
    > Cc: Linus Walleij <linus.walleij@linaro.org>
    > Cc: Pavel Machek <pavel@ucw.cz>
    > Cc: linux-leds@vger.kernel.org
    > Signed-off-by: Rob Herring <robh@kernel.org>

    Thanks for doing this!

    > v2:
    > - Drop undocumented linux,default-trigger values

    Will this lead to warnings? People tend to want to use these.

    (Possibly we could actually create operating-system independent
    triggers that make sense on any system. But it's another can
    of worms we don't need to open today.)

    > + enum:
    > + [ 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800,
    > + 0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000,
    > + 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
    > + 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]

    That's an interesting looking enum :D

    But I can't think of anything better, so:
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2021-09-14 01:01    [W:4.128 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site