Messages in this thread | | | Date | Sun, 12 Sep 2021 18:49:52 +0300 | Subject | Re: [PATCH v3] media: mxl111sf: change mutex_init() location | From | Pavel Skripkin <> |
| |
On 8/19/21 13:42, Pavel Skripkin wrote: > Syzbot reported, that mxl111sf_ctrl_msg() uses uninitialized > mutex. The problem was in wrong mutex_init() location. > > Previous mutex_init(&state->msg_lock) call was in ->init() function, but > dvb_usbv2_init() has this order of calls: > > dvb_usbv2_init() > dvb_usbv2_adapter_init() > dvb_usbv2_adapter_frontend_init() > props->frontend_attach() > > props->init() > > Since mxl111sf_* devices call mxl111sf_ctrl_msg() in ->frontend_attach() > internally we need to initialize state->msg_lock before > frontend_attach(). To achieve it, ->probe() call added to all mxl111sf_* > devices, which will simply initiaize mutex. > > Reported-and-tested-by: syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com > Fixes: 8572211842af ("[media] mxl111sf: convert to new DVB USB") > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Hi, Sean!
Did you have a chance to review this patch? Thank you :)
With regards, Pavel Skripkin
| |