lkml.org 
[lkml]   [2021]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 10/32] PCI: rcar: Fix runtime PM imbalance in rcar_pcie_ep_probe()
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 1e29cd9983eba1b596bc07f94d81d728007f8a25 ]

    pm_runtime_get_sync() will increase the runtime PM counter
    even it returns an error. Thus a pairing decrement is needed
    to prevent refcount leak. Fix this by replacing this API with
    pm_runtime_resume_and_get(), which will not change the runtime
    PM counter on error.

    Link: https://lore.kernel.org/r/20210408072402.15069-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-rcar-ep.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
    index b4a288e24aaf..c91d85b15129 100644
    --- a/drivers/pci/controller/pcie-rcar-ep.c
    +++ b/drivers/pci/controller/pcie-rcar-ep.c
    @@ -492,9 +492,9 @@ static int rcar_pcie_ep_probe(struct platform_device *pdev)
    pcie->dev = dev;

    pm_runtime_enable(dev);
    - err = pm_runtime_get_sync(dev);
    + err = pm_runtime_resume_and_get(dev);
    if (err < 0) {
    - dev_err(dev, "pm_runtime_get_sync failed\n");
    + dev_err(dev, "pm_runtime_resume_and_get failed\n");
    goto err_pm_disable;
    }

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-11 15:13    [W:4.004 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site