lkml.org 
[lkml]   [2021]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 11/22] usb: host: xhci-rcar: Dont reload firmware after the completion
    Date
    From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    commit 57f3ffdc11143f56f1314972fe86fe17a0dcde85 upstream.

    According to the datasheet, "Upon the completion of FW Download,
    there is no need to write or reload FW.". Otherwise, it's possible
    to cause unexpected behaviors. So, adds such a condition.

    Fixes: 4ac8918f3a73 ("usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers")
    Cc: stable@vger.kernel.org # v3.17+
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Link: https://lore.kernel.org/r/20210827063227.81990-1-yoshihiro.shimoda.uh@renesas.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/host/xhci-rcar.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/drivers/usb/host/xhci-rcar.c
    +++ b/drivers/usb/host/xhci-rcar.c
    @@ -134,6 +134,13 @@ static int xhci_rcar_download_firmware(s
    const struct soc_device_attribute *attr;
    const char *firmware_name;

    + /*
    + * According to the datasheet, "Upon the completion of FW Download,
    + * there is no need to write or reload FW".
    + */
    + if (readl(regs + RCAR_USB3_DL_CTRL) & RCAR_USB3_DL_CTRL_FW_SUCCESS)
    + return 0;
    +
    attr = soc_device_match(rcar_quirks_match);
    if (attr)
    quirks = (uintptr_t)attr->data;

    \
     
     \ /
      Last update: 2021-09-10 14:32    [W:6.027 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site