Messages in this thread | | | Date | Wed, 1 Sep 2021 12:54:34 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number |
| |
Em Tue, Aug 24, 2021 at 04:36:15PM +0800, Leo Yan escreveu: > On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > > Currently perf reports "Cannot allocate memory" which isn't very helpful > > for a potentially user facing issue. If we add a new magic number in > > the future, perf will be able to report unrecognised magic numbers. > > > > Signed-off-by: James Clark <james.clark@arm.com> > > Reviewed-by: Leo Yan <leo.yan@linaro.org>
Applies cleanly to my tree, test building it now, holler if there is something that prevents it from being merged.
- Arnaldo
> > --- > > tools/perf/util/cs-etm.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > index 788ad5a099f6..5b276bdb96a6 100644 > > --- a/tools/perf/util/cs-etm.c > > +++ b/tools/perf/util/cs-etm.c > > @@ -2973,6 +2973,11 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > > > /* ETE shares first part of metadata with ETMv4 */ > > trcidr_idx = CS_ETMV4_TRCTRACEIDR; > > + } else { > > + ui__error("CS ETM Trace: Unrecognised magic number %#"PRIx64". File could be from a newer version of perf.\n", > > + ptr[i]); > > + err = -EINVAL; > > + goto err_free_metadata; > > } > > > > if (!metadata[j]) { > > -- > > 2.28.0 > >
--
- Arnaldo
| |