lkml.org 
[lkml]   [2021]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 014/113] can: usb: esd_usb2: esd_usb2_rx_event(): fix the interchange of the CAN RX and TX error counters
    Date
    From: Stefan Mätje <stefan.maetje@esd.eu>

    commit 044012b52029204900af9e4230263418427f4ba4 upstream.

    This patch fixes the interchanged fetch of the CAN RX and TX error
    counters from the ESD_EV_CAN_ERROR_EXT message. The RX error counter
    is really in struct rx_msg::data[2] and the TX error counter is in
    struct rx_msg::data[3].

    Fixes: 96d8e90382dc ("can: Add driver for esd CAN-USB/2 device")
    Link: https://lore.kernel.org/r/20210825215227.4947-2-stefan.maetje@esd.eu
    Cc: stable@vger.kernel.org
    Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/usb/esd_usb2.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/can/usb/esd_usb2.c
    +++ b/drivers/net/can/usb/esd_usb2.c
    @@ -224,8 +224,8 @@ static void esd_usb2_rx_event(struct esd
    if (id == ESD_EV_CAN_ERROR_EXT) {
    u8 state = msg->msg.rx.data[0];
    u8 ecc = msg->msg.rx.data[1];
    - u8 txerr = msg->msg.rx.data[2];
    - u8 rxerr = msg->msg.rx.data[3];
    + u8 rxerr = msg->msg.rx.data[2];
    + u8 txerr = msg->msg.rx.data[3];

    skb = alloc_can_err_skb(priv->netdev, &cf);
    if (skb == NULL) {

    \
     
     \ /
      Last update: 2021-09-01 15:08    [W:4.365 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site