lkml.org 
[lkml]   [2021]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS
From
Date
On 01/09/2021 21:48, AngeloGioacchino Del Regno wrote:
> Il 01/09/21 14:15, Yassine Oudjana ha scritto:
>> SoCs such as MSM8996 also control bus QoS in a similar fashion to SDM660,
>> with some paths being controlled by RPM and others directly by the AP.
>> Move relevant functions and defines to a new object so that they can
>> be used
>> in multiple drivers.
>>
>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Hey guys!
>
> I'm waiting for the interconnect RPM-QoS commonization to be merged as I
> have fresh
> interconnect drivers for MSM8998 and MSM8976, ready to send, that are
> also using
> the very same QoS mechanism as SDM660.

We were also looking onto this. I'd propose to merge sdm660 code into
main icc-rpm.c instead of splitting it into separate file. We have
enabled QoS for apq8096 (msm8916) and msm8939. See
https://lore.kernel.org/linux-arm-msm/20210818015732.1717810-1-dmitry.baryshkov@linaro.org/
for the reference. I'm waiting for Shawn to publish v2 of his fix, then
I can post v2 of my patchset.

>
> Yassine, please check Shawn's recent patches for SDM660 interconnect,
> which are
> fixing some bits for the QoS implementation and adding some required
> clocks to the
> SDM660 interconnect driver.
>
> Adding Shawn to the Ccs as to make him aware of this patch;
> also adding Marijn and Konrad from SoMainline as probably interested
> parties.
>
> Cheers!
> - Angelo


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2021-09-02 00:03    [W:1.402 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site