Messages in this thread | | | Subject | Re: Question on commit dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()") | From | André Almeida <> | Date | Wed, 1 Sep 2021 15:28:16 -0300 |
| |
Thomas,
Às 20:29 de 30/08/21, Thomas Gleixner escreveu: > Lukas, > > On Fri, Aug 20 2021 at 13:17, Lukas Bulwahn wrote: >> Did you intend to return -EINVAL here? So: >> >> + if (!top_waiter->rt_waiter || top_waiter->pi_state) >> + return -EINVAL; > > Duh, yes. > >> Static analysis tools are as foolish as they are... but every dog has its day... > > IOW: Even a blind hen sometimes finds a grain of corn :) > > Care to send a patch? >
A patch was already proposed with this fix: https://lore.kernel.org/lkml/20210818131840.34262-1-colin.king@canonical.com/
| |