lkml.org 
[lkml]   [2021]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Question on commit dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")
From
Date
Thomas,

Às 20:29 de 30/08/21, Thomas Gleixner escreveu:
> Lukas,
>
> On Fri, Aug 20 2021 at 13:17, Lukas Bulwahn wrote:
>> Did you intend to return -EINVAL here? So:
>>
>> + if (!top_waiter->rt_waiter || top_waiter->pi_state)
>> + return -EINVAL;
>
> Duh, yes.
>
>> Static analysis tools are as foolish as they are... but every dog has its day...
>
> IOW: Even a blind hen sometimes finds a grain of corn :)
>
> Care to send a patch?
>

A patch was already proposed with this fix:
https://lore.kernel.org/lkml/20210818131840.34262-1-colin.king@canonical.com/

\
 
 \ /
  Last update: 2021-09-01 20:29    [W:0.044 / U:5.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site