Messages in this thread | | | Date | Wed, 01 Sep 2021 19:14:24 +0200 | From | "Sven Peter" <> | Subject | Re: [PATCH v2 6/8] iommu: Move IOMMU pagesize check to attach_device |
| |
On Tue, Aug 31, 2021, at 23:39, Alyssa Rosenzweig wrote: > > + if ((1 << __ffs(domain->pgsize_bitmap)) > PAGE_SIZE) { > > Not a fan of this construction. Could you assign `(1 << > __ffs(domain->pgsize_bitmap))` to an appropriately named temporary (e.g > min_io_pgsize) so it's clearer what's going on?
Good point, will do that for the next version.
> > > + pr_warn("IOMMU page size cannot represent CPU pages.\n"); > > "Represent" how? >
Looks like I dropped an "exactly" there when taking this line from iova.c :)
Thanks,
Sven
| |