Messages in this thread | | | Date | Mon, 9 Aug 2021 17:57:23 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 07/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_p2p.c |
| |
On Sat, Aug 07, 2021 at 12:11:09PM +0200, Michael Straube wrote: > @@ -155,10 +155,10 @@ static void issue_group_disc_req(struct wifidirect_info *pwdinfo, u8 *da) > pattrib->pktlen = sizeof(struct rtw_ieee80211_hdr_3addr); > > /* Build P2P action frame header */ > - pframe = rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen)); > - pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &(pattrib->pktlen)); > - pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &(pattrib->pktlen)); > - pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &(pattrib->pktlen)); > + pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen); > + pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &pattrib->pktlen); > + pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &pattrib->pktlen); > + pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &pattrib->pktlen);
Same thing as the earlier patch. Only the fourth parameter is fixed and not the others.
regards, dan carpenter
| |