lkml.org 
[lkml]   [2021]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe
    On Mon, Aug 9, 2021 at 11:32 PM Greg Kroah-Hartman
    <gregkh@linuxfoundation.org> wrote:
    >
    > On Mon, Aug 09, 2021 at 10:30:26PM +0800, Dongliang Mu wrote:
    > > The function tpci200_register called by tpci200_install and
    > > tpci200_unregister called by tpci200_uninstall are in pair. However,
    > > tpci200_unregister has some cleanup operations not in the
    > > tpci200_register. So the error handling code of tpci200_pci_probe has
    > > many different double free issues.
    > >
    > > Fix this problem by moving those cleanup operations out of
    > > tpci200_unregister, into tpci200_pci_remove and reverting
    > > the previous commit 9272e5d0028d ("ipack/carriers/tpci200:
    > > Fix a double free in tpci200_pci_probe").
    > >
    > > Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
    > > Fixes: 9272e5d0028d ("ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe")
    > > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    > > ---
    > > v1->v2: revise PATCH 2/3, 3/3, not depending on PATCH 1/3; move the
    > > location change of tpci_unregister into one separate patch;
    >
    > Also needs to go to the stable trees, right?

    Yes, this needs to go to the stable trees.

    >

    \
     
     \ /
      Last update: 2021-08-10 01:09    [W:2.960 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site