lkml.org 
[lkml]   [2021]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next, v5, 02/11] ptp: support ptp physical/virtual clocks conversion
On Fri, Aug 06, 2021 at 06:15:29PM -0700, Vinicius Costa Gomes wrote:

> > int ptp_clock_unregister(struct ptp_clock *ptp)
> > {
> > + if (ptp_vclock_in_use(ptp)) {
> > + pr_err("ptp: virtual clock in use\n");
> > + return -EBUSY;
> > + }
> > +
>
> None of the drivers (that I looked) expect ptp_clock_unregister() to
> return an error.
>
> So, what should we do?
> 1. Fix all the drivers to return an error on module unloading (that's
> usually the path ptp_clock_unregister() is called)?
> 2. Remove all the PTP virtual clocks when the physical clock is
> unregistered?

This:

3. Let the vclocks hold a reference to the underlying posix dynamic clock.


Thanks,
Richard

\
 
 \ /
  Last update: 2021-08-07 16:25    [W:1.987 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site