lkml.org 
[lkml]   [2021]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523
On Fri, Jul 30, 2021 at 03:59:01PM +0100, Mark Rutland wrote:
> On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote:
> > From: John Crispin <john@phrozen.org>
> >
> > Add basic support for EcoNet EN7523, enough for booting to console.
> >
> > The UART is basically 8250-compatible, except for the clock selection.
> > A clock-frequency value is synthesized to get this to run at 115200 bps.
> >
> > Signed-off-by: John Crispin <john@phrozen.org>
> > Signed-off-by: Bert Vermeulen <bert@biot.com>
> > ---
> > arch/arm/boot/dts/Makefile | 2 +
> > arch/arm/boot/dts/en7523-evb.dts | 17 ++++
> > arch/arm/boot/dts/en7523.dtsi | 128 +++++++++++++++++++++++++++++++
> > 3 files changed, 147 insertions(+)
> > create mode 100644 arch/arm/boot/dts/en7523-evb.dts
> > create mode 100644 arch/arm/boot/dts/en7523.dtsi
> >
>
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> > + cpu0: cpu@0 {
> > + device_type = "cpu";
> > + compatible = "arm,cortex-a7";
> > + reg = <0x0>;
> > + enable-method = "psci";
> > + clock-frequency = <80000000>;
> > + next-level-cache = <&L2_0>;
> > +
> > + };
>
> > + gic: interrupt-controller@09000000 {
> > + compatible = "arm,gic-v3";
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + reg = <0x09000000 0x20000>,
> > + <0x09080000 0x80000>;
> > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> > +
> > + its: gic-its@09020000 {
> > + compatible = "arm,gic-v3-its";
> > + msi-controller;
> > + #msi-cell = <1>;
>
> Missing 's' here for '#msi-cells'.

No need for a human to be checking this, the DT schemas will check this.
Please run 'make dtbs_checks' on this. New platforms should be free of
warnings ideally.

Rob

\
 
 \ /
  Last update: 2021-08-06 22:53    [W:0.102 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site