Messages in this thread | | | Date | Fri, 06 Aug 2021 09:21:17 +0200 | From | Michael Walle <> | Subject | Re: [PATCH] ARM: kirkwood: add missing <linux/if_ether.h> for ETH_ALEN |
| |
Hi,
Am 2021-08-06 00:23, schrieb Daniel Golle: > After commit 83216e3988cd1 ("of: net: pass the dst buffer to > of_get_mac_address()") build fails for kirkwood as ETH_ALEN is not > defined. > > arch/arm/mach-mvebu/kirkwood.c: In function 'kirkwood_dt_eth_fixup': > arch/arm/mach-mvebu/kirkwood.c:87:13: error: 'ETH_ALEN' undeclared > (first use in this function); did you mean 'ESTALE'? > u8 tmpmac[ETH_ALEN]; > ^~~~~~~~ > ESTALE > arch/arm/mach-mvebu/kirkwood.c:87:13: note: each undeclared identifier > is reported only once for each function it appears in > arch/arm/mach-mvebu/kirkwood.c:87:6: warning: unused variable 'tmpmac' > [-Wunused-variable] > u8 tmpmac[ETH_ALEN]; > ^~~~~~ > make[5]: *** [scripts/Makefile.build:262: > arch/arm/mach-mvebu/kirkwood.o] Error 1 > make[5]: *** Waiting for unfinished jobs.... > > Add missing #include <linux/if_ether.h> to fix this. > > Cc: David S. Miller <davem@davemloft.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Michael Walle <michael@walle.cc> > Reported-by: > https://buildbot.openwrt.org/master/images/#/builders/56/builds/220/steps/44/logs/stdio > Fixes: 83216e3988cd1 ("of: net: pass the dst buffer to > of_get_mac_address()") > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
What kernel is this? I've just tested with this exact commit as base and it compiles just fine.
I'm not saying including the file is wrong, but it seems it isn't needed in the upstream kernel and I don't know if it qualifies for the stable queue therefore.
-michael
| |