lkml.org 
[lkml]   [2021]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next 2/6] net: ipa: reorder netdev pointer assignments
    From
    Date
    On 8/5/21 8:27 PM, Jakub Kicinski wrote:
    > On Wed, 4 Aug 2021 10:36:22 -0500 Alex Elder wrote:
    >> Assign the ipa->modem_netdev and endpoint->netdev pointers *before*
    >> registering the network device. As soon as the device is
    >> registered it can be opened, and by that time we'll want those
    >> pointers valid.
    >>
    >> Similarly, don't make those pointers NULL until *after* the modem
    >> network device is unregistered in ipa_modem_stop().
    >>
    >> Signed-off-by: Alex Elder <elder@linaro.org>
    >
    > This one seems like a pretty legit race, net would be better if you
    > don't mind.

    I don't mind at all. But now that it's accepted, I'm not sure how
    to go about getting it back-ported. Mainly I don't want to interfere
    with any interaction between net/master and net-next/master... Maybe
    you're in a better position to do that. And if so:

    Fixes: 57f63faf0562 ("net: ipa: only set endpoint netdev pointer when in
    use")

    I'll happily do it if you can tell me the best way how. Thanks.

    -Alex

    \
     
     \ /
      Last update: 2021-08-06 13:40    [W:6.828 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site