Messages in this thread | | | From | Haris Iqbal <> | Date | Fri, 6 Aug 2021 12:09:57 +0200 | Subject | Re: [PATCH] RDMA/rtrs: Remove a useless kfree |
| |
On Thu, Aug 5, 2021 at 7:43 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing > it. It is just a no-op. > > Remove the useless kfree. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> --- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c > index ece3205531b8..fc440a08e112 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c > @@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, > } > > if (!sess->rbufs) { > - kfree(sess->rbufs); > sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs), > GFP_KERNEL); > if (!sess->rbufs) > -- > 2.30.2 >
| |