Messages in this thread Patch in this message | | | From | Yajun Deng <> | Subject | [PATCH net-next] net: sock: add the case if sk is NULL | Date | Fri, 6 Aug 2021 14:38:15 +0800 |
| |
Add the case if sk is NULL in sock_{put, hold}, The caller is free to use it.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev> --- include/net/sock.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/net/sock.h b/include/net/sock.h index 6e761451c927..8821ec0d4147 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -699,7 +699,8 @@ static inline bool __sk_del_node_init(struct sock *sk) static __always_inline void sock_hold(struct sock *sk) { - refcount_inc(&sk->sk_refcnt); + if (sk) + refcount_inc(&sk->sk_refcnt); } /* Ungrab socket in the context, which assumes that socket refcnt @@ -1811,7 +1812,7 @@ void sock_init_data(struct socket *sock, struct sock *sk); /* Ungrab socket and destroy it, if it was the last reference. */ static inline void sock_put(struct sock *sk) { - if (refcount_dec_and_test(&sk->sk_refcnt)) + if (sk && refcount_dec_and_test(&sk->sk_refcnt)) sk_free(sk); } /* Generic version of sock_put(), dealing with all sockets -- 2.32.0
| |