lkml.org 
[lkml]   [2021]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 28/35] drm/amd/display: Fix comparison error in dcn21 DML
    Date
    From: Victor Lu <victorchengchi.lu@amd.com>

    [ Upstream commit ec3102dc6b36c692104c4a0546d4119de59a3bc1 ]

    [why]
    A comparison error made it possible to not iterate through all the
    specified prefetch modes.

    [how]
    Correct "<" to "<="

    Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
    Reviewed-by: Yongqiang Sun <Yongqiang.Sun@amd.com>
    Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
    Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
    index 398210d1af34..f49743929357 100644
    --- a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
    +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
    @@ -4889,7 +4889,7 @@ void dml21_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
    }
    } while ((locals->PrefetchSupported[i][j] != true || locals->VRatioInPrefetchSupported[i][j] != true)
    && (mode_lib->vba.NextMaxVStartup != mode_lib->vba.MaxMaxVStartup[0][0]
    - || mode_lib->vba.NextPrefetchMode < mode_lib->vba.MaxPrefetchMode));
    + || mode_lib->vba.NextPrefetchMode <= mode_lib->vba.MaxPrefetchMode));

    if (locals->PrefetchSupported[i][j] == true && locals->VRatioInPrefetchSupported[i][j] == true) {
    mode_lib->vba.BandwidthAvailableForImmediateFlip = locals->ReturnBWPerState[i][0];
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-08-06 10:26    [W:4.058 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site