Messages in this thread | | | Subject | Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device | From | Christophe Leroy <> | Date | Fri, 6 Aug 2021 06:53:47 +0200 |
| |
Le 06/08/2021 à 06:39, Saravana Kannan a écrit : > On Thu, Aug 5, 2021 at 9:35 PM Maxim Kochetkov <fido_max@inbox.ru> wrote: >> >> 03.08.2021 20:51, Saravana Kannan wrote: >>>> So lets convert this driver to simple platform_device with probe(). >>>> Also use platform_get_ and devm_ family function to get/allocate >>>> resources and drop unused .compatible = "qeic". >>> Yes, please! >> >> Should I totally drop { .type = "qeic"}, or keep? > > Sorry for the confusion. My "Yes, please"!" was a show of support for > switching this to a proper platform driver. Not a response to that > specific question. > > I didn't look at the code/DT close enough to know/care about the "type" part. >
As far as I understand, Leo told it needs to remain, based on his answer below:
"From the original code, this should be type = "qeic". It is not defined in current binding but probably needed for backward compatibility."
Christophe
| |