Messages in this thread | | | Date | Fri, 6 Aug 2021 06:46:54 +0200 | From | Greg KH <> | Subject | Re: [PATCH v8 1/5] cpumask: introduce cpumap_print_to_buf to support large bitmask and list |
| |
On Thu, Aug 05, 2021 at 11:05:59PM +0000, Song Bao Hua (Barry Song) wrote: > > > +int bitmap_print_to_buf(bool list, char *buf, const unsigned long *maskp, > > > + int nmaskbits, loff_t off, size_t count) > > > > No need to put the kernel doc for both the .h and .c file, only put it > > in one place please (where ever it ties into the kernel documentation) > > > > Actually they are two different modules. One is cpumap, the other one is > bitmap. But they do have some duplicated content. > I'd prefer to remove the duplicated part from cpumap.
Ah, I missed that they were two different functions, sorry. But yes, removing duplication is good.
thanks,
greg k-h
| |