lkml.org 
[lkml]   [2021]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP)
On Wed, Jun 23, 2021 at 05:01:03PM +0300, Andy Shevchenko wrote:
> The "depends on" is no-op in the selectable options.

Same as in patch one, spell out what "depends on" you are referring
to - please make this log more descriptive.

Thanks,
Lorenzo

>
> Clean up the users of PCIE_DW_EP and introduce idiom
>
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
>
> for all of them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 9bfd41eadd5e..ca5de4e40fbe 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -12,7 +12,6 @@ config PCIE_DW_HOST
>
> config PCIE_DW_EP
> bool
> - depends on PCI_ENDPOINT
> select PCIE_DW
>
> config PCI_DRA7XX
> @@ -37,8 +36,8 @@ config PCI_DRA7XX_HOST
> config PCI_DRA7XX_EP
> bool "TI DRA7xx PCIe controller Endpoint Mode"
> depends on SOC_DRA7XX || COMPILE_TEST
> - depends on PCI_ENDPOINT
> depends on OF && HAS_IOMEM && TI_PIPE3
> + depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PCI_DRA7XX
> help
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2021-08-05 15:56    [W:0.061 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site