Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] iwlwifi: select MAC80211_LEDS conditionally | Date | Thu, 05 Aug 2021 16:44:17 +0300 |
| |
Liwei Song <liwei.song@windriver.com> writes:
> On 6/24/21 18:41, Kalle Valo wrote: >> Liwei Song <liwei.song@windriver.com> writes: >> >>> MAC80211_LEDS depends on LEDS_CLASS=y or LEDS_CLASS=MAC80211, >>> add condition to enable it in iwlwifi/Kconfig to avoid below >>> compile warning when LEDS_CLASS was set to m: >>> >>> WARNING: unmet direct dependencies detected for MAC80211_LEDS >>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && >>> (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y]) >>> Selected by [m]: >>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && >>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || >>> LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m]) >>> >>> Signed-off-by: Liwei Song <liwei.song@windriver.com> >> >> Is this is a new regression or an old bug? What commit caused this? > > It should be exist when the below commit change the dependency of MAC80211_LEDS > to fix some build error: > > commit b64acb28da8394485f0762e657470c9fc33aca4d > Author: Arnd Bergmann <arnd@arndb.de> > Date: Mon Jan 25 12:36:42 2021 +0100 > > ath9k: fix build error with LEDS_CLASS=m
Thanks, it seems LEDS_CLASS is a constant source of problems for wireless drivers :/
Luca, what should we do? We cannot have compile errors in the tree.
I assigned this patch to me on patchwork.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |