lkml.org 
[lkml]   [2021]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] DRM: gpu: radeon: Fixed coding style issues
From
Date
Am 04.08.21 um 13:20 schrieb Sergio Miguéns Iglesias:
> Fixed braces, an unnecessary if statement and added a missing space.
>
> Signed-off-by: Sergio Miguéns Iglesias <sergio@lony.xyz>

Normally we see patches which just fixes coding style as unnecessary
churn, but the "if (rbo) {}" is really ugly here.

So Reviewed-by: Christian König <christian.koenig@amd.com>.

Thanks,
Christian.

> ---
> drivers/gpu/drm/radeon/radeon_fb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 0b206b052972..6640b7c947fe 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -54,6 +54,7 @@ radeonfb_open(struct fb_info *info, int user)
> struct radeon_fbdev *rfbdev = info->par;
> struct radeon_device *rdev = rfbdev->rdev;
> int ret = pm_runtime_get_sync(rdev->ddev->dev);
> +
> if (ret < 0 && ret != -EACCES) {
> pm_runtime_mark_last_busy(rdev->ddev->dev);
> pm_runtime_put_autosuspend(rdev->ddev->dev);
> @@ -196,9 +197,8 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> radeon_bo_check_tiling(rbo, 0, 0);
> ret = radeon_bo_kmap(rbo, NULL);
> radeon_bo_unreserve(rbo);
> - if (ret) {
> + if (ret)
> goto out_unref;
> - }
>
> *gobj_p = gobj;
> return 0;
> @@ -294,9 +294,6 @@ static int radeonfb_create(struct drm_fb_helper *helper,
> return 0;
>
> out:
> - if (rbo) {
> -
> - }
> if (fb && ret) {
> drm_gem_object_put(gobj);
> drm_framebuffer_unregister_private(fb);

\
 
 \ /
  Last update: 2021-08-05 14:33    [W:0.047 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site