Messages in this thread | | | From | "Keller, Jacob E" <> | Subject | RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies | Date | Wed, 4 Aug 2021 20:53:05 +0000 |
| |
> -----Original Message----- > From: Richard Cochran <richardcochran@gmail.com> > Sent: Tuesday, August 03, 2021 1:55 PM > To: Arnd Bergmann <arnd@kernel.org> > Cc: Nicolas Pitre <nico@fluxnic.net>; Keller, Jacob E <jacob.e.keller@intel.com>; > Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jakub > Kicinski <kuba@kernel.org>; Arnd Bergmann <arnd@arndb.de>; Kurt > Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz <shiraz.saleem@intel.com>; > Ertman, David M <david.m.ertman@intel.com>; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK > dependencies > > > On Tue, Aug 03, 2021 at 07:00:49PM +0200, Arnd Bergmann wrote: > > > If you turn all those 'select' lines into 'depends on', this will work, but it's > > not actually much different from what I'm suggesting. > > "depends" instead of "select" works for me. I just want it simple and clear. > > > Maybe we can do it > > in two steps: first fix the build failure by replacing all the 'imply' > > statements > > with the correct dependencies, and then you send a patch on top that > > turns PPS and PTP_1588_CLOCK into bool options. > > Sounds good. > > Thanks, > Richard
Works for me too.
Thanks, Jake
| |