lkml.org 
[lkml]   [2021]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] scsi: ufs: Remove useless if-state in ufshcd_add_command_trace
Date
> 
> From: Bean Huo <beanhuo@micron.com>
>
> ufshcd_add_cmd_upiu_trace() will be called anyway, so move if-state down,
> make code simpler.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>


> ---
> drivers/scsi/ufs/ufshcd.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> 064a44e628d6..02f54153fd6d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -380,14 +380,11 @@ static void ufshcd_add_command_trace(struct
> ufs_hba *hba, unsigned int tag,
> if (!cmd)
> return;
>
> - if (!trace_ufshcd_command_enabled()) {
> - /* trace UPIU W/O tracing command */
> - ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> - return;
> - }
> -
> /* trace UPIU also */
> ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> + if (!trace_ufshcd_command_enabled())
> + return;
> +
> opcode = cmd->cmnd[0];
> lba = scsi_get_lba(cmd);
>
> --
> 2.25.1

\
 
 \ /
  Last update: 2021-08-04 08:38    [W:0.092 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site