Messages in this thread | | | Date | Wed, 04 Aug 2021 15:23:38 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 2/9] irqchip/loongson-pch-pic: Improve edge triggered interrupt support |
| |
On Fri, 09 Jul 2021 04:00:58 +0100, Huacai Chen <chenhuacai@gmail.com> wrote: > > Hi, Marc, > > On Tue, Jul 6, 2021 at 9:06 PM Marc Zyngier <maz@kernel.org> wrote: > > > > On Tue, 06 Jul 2021 04:08:57 +0100, > > Huacai Chen <chenhuacai@loongson.cn> wrote: > > > > > > Edge-triggered mode and level-triggered mode need different handlers, > > > and edge-triggered mode need a specific ack operation. So improve it. > > > > > > > Is this a fix? How does it work currently? > Yes, some devices (e.g., RTC) is edge-triggered, they need > handle_edge_irq(). Currently we don't use RTC interrupt in the > upstream kernel on Loongson platform, so it "works".
If you want me to queue this independently of the full LoongArch series, please resend it with a Fixes: tag.
Thanks,
M.
-- Without deviation from the norm, progress is not possible.
| |