lkml.org 
[lkml]   [2021]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 17/37] perf evsel: separate missing feature disabling from evsel__open_cpu
Em Sat, Aug 21, 2021 at 11:19:23AM +0200, Riccardo Mancini escreveu:
> This is a preparatory patch for the following patches with the goal to
> separate in evlist__open_cpu the actual opening, which could be
> performed in parallel, from the existing fallback mechanisms, which
> should be handled sequentially.
>
> This patch separates the disabling of missing features from
> evlist__open_cpu into a new function evsel__disable_missing_features.


Thanks, applied as the end result is the same.

- Arnaldo


> Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
> ---
> tools/perf/util/evsel.c | 57 ++++++++++++++++++++++-------------------
> 1 file changed, 31 insertions(+), 26 deletions(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 509a2970a94b3142..f0bc89f743915800 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1794,33 +1794,8 @@ static int __evsel__prepare_open(struct evsel *evsel, struct perf_cpu_map *cpus,
> return 0;
> }
>
> -static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
> - struct perf_thread_map *threads,
> - int start_cpu, int end_cpu)
> +static void evsel__disable_missing_features(struct evsel *evsel)
> {
> - int cpu, thread, nthreads;
> - int pid = -1, err, old_errno;
> - enum { NO_CHANGE, SET_TO_MAX, INCREASED_MAX } set_rlimit = NO_CHANGE;
> -
> - err = __evsel__prepare_open(evsel, cpus, threads);
> - if (err)
> - return err;
> -
> - if (cpus == NULL)
> - cpus = empty_cpu_map;
> -
> - if (threads == NULL)
> - threads = empty_thread_map;
> -
> - if (evsel->core.system_wide)
> - nthreads = 1;
> - else
> - nthreads = threads->nr;
> -
> - if (evsel->cgrp)
> - pid = evsel->cgrp->fd;
> -
> -fallback_missing_features:
> if (perf_missing_features.weight_struct) {
> evsel__set_sample_bit(evsel, WEIGHT);
> evsel__reset_sample_bit(evsel, WEIGHT_STRUCT);
> @@ -1850,6 +1825,36 @@ static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
> evsel->core.attr.branch_sample_type &= ~PERF_SAMPLE_BRANCH_HW_INDEX;
> if (perf_missing_features.sample_id_all)
> evsel->core.attr.sample_id_all = 0;
> +}
> +
> +static int evsel__open_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
> + struct perf_thread_map *threads,
> + int start_cpu, int end_cpu)
> +{
> + int cpu, thread, nthreads;
> + int pid = -1, err, old_errno;
> + enum { NO_CHANGE, SET_TO_MAX, INCREASED_MAX } set_rlimit = NO_CHANGE;
> +
> + err = __evsel__prepare_open(evsel, cpus, threads);
> + if (err)
> + return err;
> +
> + if (cpus == NULL)
> + cpus = empty_cpu_map;
> +
> + if (threads == NULL)
> + threads = empty_thread_map;
> +
> + if (evsel->core.system_wide)
> + nthreads = 1;
> + else
> + nthreads = threads->nr;
> +
> + if (evsel->cgrp)
> + pid = evsel->cgrp->fd;
> +
> +fallback_missing_features:
> + evsel__disable_missing_features(evsel);
>
> display_attr(&evsel->core.attr);
>
> --
> 2.31.1

--

- Arnaldo

\
 
 \ /
  Last update: 2021-08-31 21:37    [W:0.300 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site