Messages in this thread | | | From | David Hildenbrand <> | Subject | Re: [PATCH 5/6] mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype | Date | Tue, 31 Aug 2021 16:23:07 +0200 |
| |
On 31.08.21 15:43, Mel Gorman wrote: > On Mon, Aug 30, 2021 at 10:10:50PM +0800, Miaohe Lin wrote: >> If it's not prepared to free unref page, the pcp page migratetype is >> unset. Thus We will get rubbish from get_pcppage_migratetype() and >> might list_del &page->lru again after it's already deleted from the >> list leading to grumble about data corruption. >> >> Fixes: 3dcbe270d8ec ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock") >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > > Acked-by: Mel Gorman <mgorman@techsingularity.net> > > This fix is fairly important. Take this patch out and send it on its own > so it gets picked up relatively quickly. It does not belong in a series > that is mostly cosmetic cleanups.
I think the commit id is wrong. Shouldn't that be
df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock")
?
-- Thanks,
David / dhildenb
| |