Messages in this thread | | | From | Rocco Yue <> | Subject | Re: [PATCH net-next v2] ipv6: add IFLA_INET6_RA_MTU to expose mtu value in the RA message | Date | Tue, 3 Aug 2021 19:57:59 +0800 |
| |
On Mon, 2021-08-02 at 07:35 -0600, David Ahern wrote: > On 8/2/21 6:40 AM, Rocco Yue wrote: >> >> Regarding setting "reject_message" in the policy, after reviewing >> the code, I fell that it is unnecessary, because the cost of >> implementing it seems to be a bit high, which requires modifying >> the function interface. The reasons is as follows: > > The policy can be setup now to do the right thing once the extack > argument is available. > > do_setlink() has an extack argument. It calls validate_linkmsg which > calls validate_link_af meaning support can be added in a single patch. > If you decide to do it, then it should be a separate patch preceding > this one. >
Hi David,
Thanks for your advice, I will send a separate patch to add extack arg firstly.
> Then userspace should get a link notification when ra_mtu is set so it > does not have to poll.
It make sense, I will do it.
Thanks Rocco
| |