Messages in this thread | | | Subject | Re: [PATCH v1 2/5] platform/surface: aggregator: Use serdev_acpi_get_uart_resource() helper | From | Maximilian Luz <> | Date | Tue, 3 Aug 2021 21:47:09 +0200 |
| |
On 8/3/21 9:29 PM, Andy Shevchenko wrote: > serdev provides a generic helper to get UART Serial Bus resources. > Use it instead of open coded variant. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks! Looks good to me.
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
> --- > drivers/platform/surface/aggregator/core.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/platform/surface/aggregator/core.c b/drivers/platform/surface/aggregator/core.c > index 279d9df19c01..c61bbeeec2df 100644 > --- a/drivers/platform/surface/aggregator/core.c > +++ b/drivers/platform/surface/aggregator/core.c > @@ -301,20 +301,13 @@ static acpi_status ssam_serdev_setup_via_acpi_crs(struct acpi_resource *rsc, > void *ctx) > { > struct serdev_device *serdev = ctx; > - struct acpi_resource_common_serialbus *serial; > struct acpi_resource_uart_serialbus *uart; > bool flow_control; > int status = 0; > > - if (rsc->type != ACPI_RESOURCE_TYPE_SERIAL_BUS) > + if (!serdev_acpi_get_uart_resource(rsc, &uart)) > return AE_OK; > > - serial = &rsc->data.common_serial_bus; > - if (serial->type != ACPI_RESOURCE_SERIAL_TYPE_UART) > - return AE_OK; > - > - uart = &rsc->data.uart_serial_bus; > - > /* Set up serdev device. */ > serdev_device_set_baudrate(serdev, uart->default_baud_rate); > >
| |