Messages in this thread | | | Date | Fri, 27 Aug 2021 11:09:28 +1200 | From | Luke Jones <> | Subject | Re: [PATCH v4 0/1] asus-wmi: Add support for custom fan curves |
| |
I will be submitting a V5 later today. While prepping for v5 I've done my best to minimise potential blockers in review according to what I've learned through past reviews :)
On Fri, Aug 20 2021 at 21:57:25 +1200, Luke D. Jones <luke@ljones.dev> wrote: > Add support for custom fan curves found on some ASUS ROG laptops. > > The patch has gone through a few revisions as others tested it and > requested bahaviour changes or reported issues. V4 should be > considered > finalised for now and I won't submit a new version until V4 has been > reviewed. > > - V1 > + Initial patch work > - V2 > + Don't fail and remove wmi driver if error from > asus_wmi_evaluate_method_buf() if error is -ENODEV > - V3 > + Store the "default" fan curves > + Call throttle_thermal_policy_write() if a curve is erased to > ensure > that the factory default for a profile is applied again > - V4 > + Do not apply default curves by default. Testers have found that > the > default curves don't quite match actual no-curve behaviours > + Add method to enable/disable curves for each profile > > Luke D. Jones (1): > asus-wmi: Add support for custom fan curves > > drivers/platform/x86/asus-wmi.c | 672 > +++++++++++++++++++++ > include/linux/platform_data/x86/asus-wmi.h | 2 + > 2 files changed, 674 insertions(+) > > -- > 2.31.1 >
| |