Messages in this thread | | | Date | Wed, 25 Aug 2021 19:18:50 +0200 | From | Peter Zijlstra <> | Subject | Re: 答复 : [PATCH] rbtree: stop iteration early in rb_find_first |
| |
On Wed, Aug 25, 2021 at 04:01:53PM +0000, Li,Rongqing wrote: > > >> > >> > >> 10 > >> / > >> 5 > >> \ > >> 10 > >> > >> The search would stop after visiting node 5, and miss the leaf which > >> is the expected node to be returned. > > thanks for explanation. > > >Just to clarify; the current code *does* work here. The proposed patch > >breaks it. > > > true, my patch is wrong. > > but rb_find_first seems have other issue. when the key is equal, we should search right leaf, not left leaf
That again breaks the above case.
| |