Messages in this thread | | | Date | Wed, 25 Aug 2021 06:22:07 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings |
| |
On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote: > From: kernel test robot <lkp@intel.com> > > drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here > > Remove unneeded conversion to bool > > Semantic patch information: > Relational and logical operators evaluate to bool, > explicit conversion is overly verbose and unneeded. > > Generated by: scripts/coccinelle/misc/boolconv.cocci > > Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible") > CC: Oleksij Rempel <o.rempel@pengutronix.de> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 372b2891c15acbf7b90d948b08ac174bde77102c > commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible > :::::: branch date: 12 hours ago > :::::: commit date: 35 hours ago > > asix_devices.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d > return ret; > > priv->phy_addr = ret; > - priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false); > + priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); > > asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); > chipcode &= AX_CHIPCODE_MASK; >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |