lkml.org 
[lkml]   [2021]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mxser: use semi-colons instead of commas
From
Date
On 25. 08. 21, 9:24, Dan Carpenter wrote:
> This code works, but it's cleaner to use semi-colons at the end of
> a statement instead of a comma.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Jiri Slaby <jirislaby@kernel.org>

> ---
> drivers/tty/mxser.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
> index 335e4e50d679..1216f3985e18 100644
> --- a/drivers/tty/mxser.c
> +++ b/drivers/tty/mxser.c
> @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty,
> if (closing_wait != ASYNC_CLOSING_WAIT_NONE)
> closing_wait = jiffies_to_msecs(closing_wait) / 10;
>
> - ss->type = info->type,
> - ss->line = tty->index,
> - ss->port = info->ioaddr,
> - ss->irq = info->board->irq,
> - ss->flags = info->port.flags,
> - ss->baud_base = MXSER_BAUD_BASE,
> + ss->type = info->type;
> + ss->line = tty->index;
> + ss->port = info->ioaddr;
> + ss->irq = info->board->irq;
> + ss->flags = info->port.flags;
> + ss->baud_base = MXSER_BAUD_BASE;
> ss->close_delay = close_delay;
> ss->closing_wait = closing_wait;
> ss->custom_divisor = MXSER_CUSTOM_DIVISOR,
>


--
js
suse labs

\
 
 \ /
  Last update: 2021-08-25 14:58    [W:0.155 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site