Messages in this thread | | | From | Stephen Boyd <> | Date | Thu, 26 Aug 2021 01:21:51 +0000 | Subject | Re: [PATCH v2 4/5] drm/msm/dp: Store each subblock in the io region |
| |
Quoting Bjorn Andersson (2021-08-25 15:25:56) > Not all platforms has DP_P0 at offset 0x1000 from the beginning of the > DP block. So split the dss_io_data memory region into a set of > sub-regions, to make it possible in the next patch to specify each of > the sub-regions individually. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > ---
One nit below:
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h b/drivers/gpu/drm/msm/dp/dp_parser.h > index dc62e70b1640..a95b05dbb11c 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.h > +++ b/drivers/gpu/drm/msm/dp/dp_parser.h > @@ -25,9 +25,16 @@ enum dp_pm_type { > DP_MAX_PM > }; > > -struct dss_io_data { > - size_t len; > +struct dss_io_region { > void __iomem *base; > + size_t len;
It flip flops here. Would be nice to the diff if len was where it really wanted to be.
> +}; > + > +struct dss_io_data { > + struct dss_io_region ahb; > + struct dss_io_region aux; > + struct dss_io_region link; > + struct dss_io_region p0; > };
| |