Messages in this thread | | | Subject | Re: [PATCH linux-next] tools:test_xdp_noinline: fix boolreturn.cocci warnings | From | Shuah Khan <> | Date | Tue, 24 Aug 2021 09:52:00 -0600 |
| |
On 8/24/21 8:46 AM, Jakub Kicinski wrote: > On Tue, 24 Aug 2021 08:42:15 -0600 Shuah Khan wrote: >> On 8/24/21 12:55 AM, CGEL wrote: >>> From: Jing Yangyang <jing.yangyang@zte.com.cn> >>> >>> Return statements in functions returning bool should use true/false >>> instead of 1/0. >>> >>> Reported-by: Zeal Robot <zealci@zte.com.cn> >>> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn> >> >> We can't accept this patch. The from and Signed-off-by don't match. > > That's what I thought but there is a From in the email body which git > will pick up. The submission is correct. >
Missed that. Thanks.
> Please trim your responses. >
Will do.
thanks, -- Shuah
| |