lkml.org 
[lkml]   [2021]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v11 03/12] vdpa: Fix some coding style issues
    On Wed, Aug 18, 2021 at 08:06:33PM +0800, Xie Yongji wrote:
    >Fix some code indent issues and following checkpatch warning:
    >
    >WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
    >371: FILE: include/linux/vdpa.h:371:
    >+static inline void vdpa_get_config(struct vdpa_device *vdev, unsigned offset,
    >
    >Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
    >---
    > include/linux/vdpa.h | 34 +++++++++++++++++-----------------
    > 1 file changed, 17 insertions(+), 17 deletions(-)

    Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

    >
    >diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
    >index 954b340f6c2f..8a645f8f4476 100644
    >--- a/include/linux/vdpa.h
    >+++ b/include/linux/vdpa.h
    >@@ -43,17 +43,17 @@ struct vdpa_vq_state_split {
    > * @last_used_idx: used index
    > */
    > struct vdpa_vq_state_packed {
    >- u16 last_avail_counter:1;
    >- u16 last_avail_idx:15;
    >- u16 last_used_counter:1;
    >- u16 last_used_idx:15;
    >+ u16 last_avail_counter:1;
    >+ u16 last_avail_idx:15;
    >+ u16 last_used_counter:1;
    >+ u16 last_used_idx:15;
    > };
    >
    > struct vdpa_vq_state {
    >- union {
    >- struct vdpa_vq_state_split split;
    >- struct vdpa_vq_state_packed packed;
    >- };
    >+ union {
    >+ struct vdpa_vq_state_split split;
    >+ struct vdpa_vq_state_packed packed;
    >+ };
    > };
    >
    > struct vdpa_mgmt_dev;
    >@@ -131,7 +131,7 @@ struct vdpa_iova_range {
    > * @vdev: vdpa device
    > * @idx: virtqueue index
    > * @state: pointer to returned state (last_avail_idx)
    >- * @get_vq_notification: Get the notification area for a virtqueue
    >+ * @get_vq_notification: Get the notification area for a virtqueue
    > * @vdev: vdpa device
    > * @idx: virtqueue index
    > * Returns the notifcation area
    >@@ -353,25 +353,25 @@ static inline struct device *vdpa_get_dma_dev(struct vdpa_device *vdev)
    >
    > static inline void vdpa_reset(struct vdpa_device *vdev)
    > {
    >- const struct vdpa_config_ops *ops = vdev->config;
    >+ const struct vdpa_config_ops *ops = vdev->config;
    >
    > vdev->features_valid = false;
    >- ops->set_status(vdev, 0);
    >+ ops->set_status(vdev, 0);
    > }
    >
    > static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features)
    > {
    >- const struct vdpa_config_ops *ops = vdev->config;
    >+ const struct vdpa_config_ops *ops = vdev->config;
    >
    > vdev->features_valid = true;
    >- return ops->set_features(vdev, features);
    >+ return ops->set_features(vdev, features);
    > }
    >
    >-
    >-static inline void vdpa_get_config(struct vdpa_device *vdev, unsigned offset,
    >- void *buf, unsigned int len)
    >+static inline void vdpa_get_config(struct vdpa_device *vdev,
    >+ unsigned int offset, void *buf,
    >+ unsigned int len)
    > {
    >- const struct vdpa_config_ops *ops = vdev->config;
    >+ const struct vdpa_config_ops *ops = vdev->config;
    >
    > /*
    > * Config accesses aren't supposed to trigger before features are set.
    >--
    >2.11.0
    >

    \
     
     \ /
      Last update: 2021-08-24 13:10    [W:4.330 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site