Messages in this thread | | | Date | Tue, 24 Aug 2021 20:37:14 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 |
| |
On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote: > On Tue, Aug 24, 2021 at 07:57:42PM +0300, Vladimir Oltean wrote: > > I understand that this is how you noticed the issue, but please remember > > that one can always compile a kernel with CONFIG_VLAN_8021Q=n. So the > > issue predates my patch by much longer. You might reconsider the Fixes: > > tag in light of this, maybe the patch needs to be sent to stable. > > Okay. So the Fixes tag should be 6087175b7991, which initially adds the > software fallback support for mt7530.
Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you saying that since the VLAN table lookup was bypassed completely in the old code, 'no VLAN 0' was an inconsequential error?
I think it's the latter. Just wanted to make sure. So that means, either this Fixes: tag or the other, the patch still belongs to net-next. From my side you shouldn't need to resend.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> > > +static int > > > +mt7530_setup_vlan0(struct mt7530_priv *priv) > > > +{ > > > + u32 val; > > > + > > > + /* Validate the entry with independent learning, keep the original > > > + * ingress tag attribute. > > > + */ > > > + val = IVL_MAC | EG_CON | PORT_MEM(MT7530_ALL_MEMBERS) | FID(FID_BRIDGED) | > > > > FID_BRIDGED? > > What's wrong with that?
Nothing, I had a senior moment and I forgot how mt7530 sets up things.
| |