Messages in this thread | | | Date | Mon, 23 Aug 2021 19:37:57 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH linux-next] s390:raw3270: Convert sysfs sprintf/snprintf family to sysfs_emit |
| |
On Fri, Aug 20, 2021 at 08:53:58PM -0700, CGEL wrote: > From: jing yangyang <jing.yangyang@zte.com.cn> > > Fix the following coccicheck warning: > ./drivers/s390/char/raw3270.c:1066:8-16: WARNING: use scnprintf or sprintf > ./drivers/s390/char/raw3270.c:1050:8-16: WARNING:use scnprintf or sprintf > ./drivers/s390/char/raw3270.c:1058:8-16: WARNING:use scnprintf or sprintf > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> ... > static ssize_t > raw3270_model_show(struct device *dev, struct device_attribute *attr, char *buf) > { > - return snprintf(buf, PAGE_SIZE, "%i\n", > + return sysfs_emit(buf, "%i\n", > ((struct raw3270 *) dev_get_drvdata(dev))->model);
Identation of the line following the patched line is now incorrect. Also the sign-off chain is not correct - I also doubt that "CGEL" is a person, but what do I know.
Not applied.
| |