lkml.org 
[lkml]   [2021]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 02/18] opp: remove WARN when no valid OPPs remain
    Date
    From: Michał Mirosław <mirq-linux@rere.qmqm.pl>

    [ Upstream commit 335ffab3ef864539e814b9a2903b0ae420c1c067 ]

    This WARN can be triggered per-core and the stack trace is not useful.
    Replace it with plain dev_err(). Fix a comment while at it.

    Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/opp/of.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/opp/of.c b/drivers/opp/of.c
    index 363277b31ecb..d92a1bfe1690 100644
    --- a/drivers/opp/of.c
    +++ b/drivers/opp/of.c
    @@ -870,8 +870,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
    }
    }

    - /* There should be one of more OPP defined */
    - if (WARN_ON(!count)) {
    + /* There should be one or more OPPs defined */
    + if (!count) {
    + dev_err(dev, "%s: no supported OPPs", __func__);
    ret = -ENOENT;
    goto remove_static_opp;
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-08-24 03:02    [W:4.474 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site