lkml.org 
[lkml]   [2021]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] serial: 8250_ingenic: Use of_device_get_match_data
Hi,

Le dim., août 22 2021 at 11:28:04 +0800, Tang Bin
<tangbin@cmss.chinamobile.com> a écrit :
> Retrieve OF match data, it's better and cleaner to use
> 'of_device_get_match_data' over 'of_match_device'.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
> drivers/tty/serial/8250/8250_ingenic.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ingenic.c
> b/drivers/tty/serial/8250/8250_ingenic.c
> index 988bf6bcc..65402d05e 100644
> --- a/drivers/tty/serial/8250/8250_ingenic.c
> +++ b/drivers/tty/serial/8250/8250_ingenic.c
> @@ -209,16 +209,14 @@ static int ingenic_uart_probe(struct
> platform_device *pdev)
> struct uart_8250_port uart = {};
> struct ingenic_uart_data *data;
> const struct ingenic_uart_config *cdata;
> - const struct of_device_id *match;
> struct resource *regs;
> int irq, err, line;
>
> - match = of_match_device(of_match, &pdev->dev);
> - if (!match) {
> + cdata = of_device_get_match_data(&pdev->dev);
> + if (!cdata) {
> dev_err(&pdev->dev, "Error: No device match found\n");
> return -ENODEV;
> }
> - cdata = match->data;
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> --
> 2.20.1.windows.1
>
>
>


\
 
 \ /
  Last update: 2021-08-22 13:17    [W:0.065 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site