Messages in this thread | | | From | Brad Larson <> | Date | Sun, 22 Aug 2021 18:25:35 -0700 | Subject | Re: [PATCH v2 03/13] spi: dw: Add support for Pensando Elba SoC SPI |
| |
Hi Andy,
On Mon, Mar 29, 2021 at 3:43 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Mar 29, 2021 at 5:01 AM Brad Larson <brad@pensando.io> wrote: > > > > The Pensando Elba SoC uses a GPIO based chip select > > for two DW SPI busses with each bus having two > > chip selects. ... > > +static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable) > > +{ > > + struct dw_spi *dws = spi_master_get_devdata(spi->master); > > + > > + if (!enable) { > > Can you use positive conditional?
This function has been re-written to use the existing dw_spi_set_cs(). This is what I currently plan for the v3 patchset.
static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable) { spi->chip_select = 0; dw_spi_set_cs(spi, enable); }
Regards, Brad
| |